[webkit-reviews] review granted: [Bug 103475] documentElement should not always get a renderer : [Attachment 176842] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Elliott Sprehn
<esprehn at chromium.org>'s request for review:
Bug 103475: documentElement should not always get a renderer
https://bugs.webkit.org/show_bug.cgi?id=103475

Attachment 176842: Patch
https://bugs.webkit.org/attachment.cgi?id=176842&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176842&action=review


Looks good. Please just fix the comment and close bug 103681.

>>> LayoutTests/fast/css/display-none-documentElement.html:11
>>> +	 */
>> 
>> I'm confused by this comment. Bug 103681 points to this bug saying that this
bug fixes it. Normally we don't include links to the fixed bug in the test
content. Am I misunderstanding?
> 
> This test case is just super weird to understand so I filed a bug explaining
it. I can just put the explanation here instead?

Yeah. I think a simple comment here like "// Test display:none on a
non-HTMLElement that is the documentElement" is sufficient.