[webkit-reviews] review granted: [Bug 103702] PluginDocument fires didFinishDocumentLoadForFrame upon receiving initial bytes instead of when load completes : [Attachment 176905] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 30 15:25:35 PST 2012


Alexey Proskuryakov <ap at webkit.org> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 103702: PluginDocument fires didFinishDocumentLoadForFrame upon receiving
initial bytes instead of when load completes
https://bugs.webkit.org/show_bug.cgi?id=103702

Attachment 176905: patch
https://bugs.webkit.org/attachment.cgi?id=176905&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
r=me

I think that the new behavior is correct for the load event, but not logical
for DOMContentLoaded.

However, the purpose of this bug is to get client delegates at the right time,
and timing of DOM events doesn't matter nearly as much. Also, I'm not sure if
the change of behavior for DOMContentLoaded is even observable.

Please update the bug title to track what we actually want to fix in Bugzilla
and in ChangeLog.


More information about the webkit-reviews mailing list