[webkit-reviews] review denied: [Bug 103513] Provide the backend for exposing the layer tree to the Web Inspector : [Attachment 176977] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Antoine Quint
<graouts at apple.com>'s request for review:
Bug 103513: Provide the backend for exposing the layer tree to the Web
Inspector
https://bugs.webkit.org/show_bug.cgi?id=103513

Attachment 176977: Patch
https://bugs.webkit.org/attachment.cgi?id=176977&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176977&action=review


Overall, it looks good, I think it is Ok to proceed with the test.

> Source/WebCore/inspector/Inspector.json:3264
> +		   "hidden": true

nit: here and below, no need to hide methods of the hidden domain.

> Source/WebCore/inspector/InspectorLayerTreeAgent.cpp:218
> +    const RenderLayer* renderLayer = m_idToLayer.get(layerId);

this can be 0 and you should return an error for this.

> Source/WebCore/rendering/RenderLayerCompositor.cpp:514
> +    InspectorInstrumentation::layerTreeDidChange(this->page());

just page() ?

> Source/WebCore/rendering/RenderLayerCompositor.cpp:520
> +    InspectorInstrumentation::renderLayerDestroyed(this->page(),
renderLayer);

ditto