[webkit-reviews] review granted: [Bug 86031] [HTMLTemplateElement] Implement DOM element and parser changes : [Attachment 176990] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Rafael Weinstein
<rafaelw at chromium.org>'s request for review:
Bug 86031: [HTMLTemplateElement] Implement DOM element and parser changes
https://bugs.webkit.org/show_bug.cgi?id=86031

Attachment 176990: Patch
https://bugs.webkit.org/attachment.cgi?id=176990&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176990&action=review


Looks like you've got a compile problem on EFL.

> Source/WebCore/WebCore.vcproj/WebCore.vcproj:9680
> +	       <File

Looks like you have spaces here rather than tabs.  This is one of the rare
files in WebKit that uses tabs.

> Source/WebCore/css/html.css:1267
> +template {
> +    display: none
> +}

Does this need to be conditional on ENABLE(TEMPLATE_ELEMENT) ?

> Source/WebCore/html/HTMLTagNames.in:127
> +template interfaceName=HTMLTemplateElement, conditional=TEMPLATE_ELEMENT

You shouldn't need the interfaceName attribute.  The default here is going to
be HTMLTemplateElement.  textarea needs it because the first A is capitalized.

> Source/WebCore/html/HTMLTemplateElement.cpp:68
> +

You've got an extra blank line here.