[webkit-reviews] review granted: [Bug 103690] RenderBlock minor clean-up: replace raw pointers with OwnPtrs. : [Attachment 176869] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 30 13:32:07 PST 2012
Eric Seidel <eric at webkit.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 103690: RenderBlock minor clean-up: replace raw pointers with OwnPtrs.
https://bugs.webkit.org/show_bug.cgi?id=103690
Attachment 176869: Patch
https://bugs.webkit.org/attachment.cgi?id=176869&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
This seems reasonable. A little scary, but reasonable. I agree with Adam that
putting adoptPtr on the same line as new is better. It might complicate a
couple callers as you couldn't use a raw pointer for a local though.
More information about the webkit-reviews
mailing list