[webkit-reviews] review denied: [Bug 101288] [EFL]Drawing artifacts while resizing the view : [Attachment 176942] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Joone Hur
<joone at webkit.org>'s request for review:
Bug 101288: [EFL]Drawing artifacts while resizing the view
https://bugs.webkit.org/show_bug.cgi?id=101288

Attachment 176942: Patch
https://bugs.webkit.org/attachment.cgi?id=176942&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176942&action=review


Nice! just a few nits

> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:119
> +#if USE(ACCELERATED_COMPOSITING)
> +    , m_isResized(false)
> +#endif

m_pendingSurfaceResize

> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:368
> +	   // Create a GL surface here not to give a chance to Evas to paint
the empty GL surface.

Create a GL surface here so that Evas has no chance of painting to an empty GL
surface.

> Source/WebKit2/UIProcess/API/efl/EwkViewImpl.h:164
> +    void setResized(bool resized) { m_isResized = resized; }

setNeedsSurfaceResize() { m_pendingSurfaceResize = true; }

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:390
> -	   if (width && height)
> -	       impl->createGLSurface(IntSize(width, height));
> +	   impl->setResized(true);

impl->setNeedsSurfaceResize(true)