[webkit-reviews] review granted: [Bug 103428] [WK2] TiledBackingStore: Frame view re-layouts with wrong Fixed Visible Content Rect. : [Attachment 176936] patch v2

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Mikhail Pozdnyakov
<mikhail.pozdnyakov at intel.com>'s request for review:
Bug 103428: [WK2] TiledBackingStore: Frame view re-layouts with wrong Fixed
Visible Content Rect.
https://bugs.webkit.org/show_bug.cgi?id=103428

Attachment 176936: patch v2
https://bugs.webkit.org/attachment.cgi?id=176936&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176936&action=review


> Source/WebKit2/UIProcess/PageViewportController.cpp:237
>      if (updateMinimumScaleToFit(true))
>	   m_client->didChangeViewportAttributes();
> -
> -    syncVisibleContents();
>  }

Maybe a comment here some how? that this is not needed

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1032
> +    // Keep the current position, update size only.
> +    FrameView* view = m_page->mainFrame()->view();
> +    IntPoint contentFixedOrigin =
view->fixedVisibleContentRect().location();

It should be mentioned here that this is indeed (0, 0) for new loads and not
the position for the previous page

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1041
> -    setFixedLayoutSize(IntSize(static_cast<int>(attr.layoutSize.width()),
static_cast<int>(attr.layoutSize.height())));
> +    setFixedLayoutSize(roundedIntSize(attr.layoutSize));

much nicer