[webkit-reviews] review granted: [Bug 103229] [EFL][WK2] Duplicated WebPageGroup initialization : [Attachment 175942] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Jinwoo Song
<jinwoo7.song at samsung.com>'s request for review:
Bug 103229: [EFL][WK2] Duplicated WebPageGroup initialization
https://bugs.webkit.org/show_bug.cgi?id=103229

Attachment 175942: Patch
https://bugs.webkit.org/attachment.cgi?id=175942&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=175942&action=review


> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:512
>      ASSERT(!smartData->priv);
> -    RefPtr<WebPageGroup> pageGroup = pageGroupRef ? toImpl(pageGroupRef) :
WebPageGroup::create();
> -    smartData->priv = new EwkViewImpl(ewkView, context, pageGroup,
behavior);
> +    smartData->priv = new EwkViewImpl(ewkView, context,
toImpl(pageGroupRef), behavior);
>      return ewkView;

I wonder whether we should add a comment?