[webkit-reviews] review granted: [Bug 103710] [EFL][WK2][AC] USE_GRAPHICS_SURFACE should be enabled only if Xcomposite and Xrender extensions are found : [Attachment 176908] GraphicsSurfaceConfig

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Kalyan
<kalyan.kondapally at intel.com>'s request for review:
Bug 103710: [EFL][WK2][AC] USE_GRAPHICS_SURFACE should be enabled only if
Xcomposite and Xrender extensions are found
https://bugs.webkit.org/show_bug.cgi?id=103710

Attachment 176908: GraphicsSurfaceConfig
https://bugs.webkit.org/attachment.cgi?id=176908&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176908&action=review


> ChangeLog:4
> +	   [EFL][WK2][AC] USE_GRAPHICS_SURFACE should be enabled only if
Xcomposite and Xrender extensions are found.
> +	   https://bugs.webkit.org/show_bug.cgi?id=103710.

I guess we need similar checks for EGL

> Source/cmake/OptionsEfl.cmake:196
> -  SET (ENABLE_WEBGL 1)
> -  ADD_DEFINITIONS(-DWTF_USE_GRAPHICS_SURFACE=1)
> +    SET(ENABLE_WEBGL 1)
> +    IF (USE_GRAPHICS_SURFACE)
> +	   ADD_DEFINITIONS(-DWTF_USE_GRAPHICS_SURFACE=1)
> +    ENDIF()
>  ENDIF()
>  

isnt the identation wrong?