[webkit-reviews] review denied: [Bug 103120] Web Inspector: Calculate "idle" time for CPU profiles. : [Attachment 176866] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Eugene Klyuchnikov
<eustas at chromium.org>'s request for review:
Bug 103120: Web Inspector: Calculate "idle" time for CPU profiles.
https://bugs.webkit.org/show_bug.cgi?id=103120

Attachment 176866: Patch
https://bugs.webkit.org/attachment.cgi?id=176866&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176866&action=review


> Source/WebCore/bindings/js/ScriptProfile.cpp:80
> +    return 0.0;

You should provide the same implementation for JSC as you provide for v8.

> Source/WebCore/inspector/InspectorProfilerAgent.cpp:388
> +    m_idleTime = 0.0;

There is a way to record nested profiles using console.profile /
console.profileEnd. So you might need to have an idle time per profile. I know
this makes things more complex.

> Source/WebCore/inspector/ScriptProfile.idl:36
> +    readonly attribute double idleTime;

Yury, do we need to change V8ScriptProfile.cpp for it to be exposed on
web-facing object in v8?