[webkit-reviews] review denied: [Bug 103647] [chromium] Mark last input event for current vsync interval : [Attachment 176749] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 29 18:16:47 PST 2012
James Robinson <jamesr at chromium.org> has denied Sami Kyöstilä
<skyostil at chromium.org>'s request for review:
Bug 103647: [chromium] Mark last input event for current vsync interval
https://bugs.webkit.org/show_bug.cgi?id=103647
Attachment 176749: Patch
https://bugs.webkit.org/attachment.cgi?id=176749&action=review
------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176749&action=review
> Source/WebKit/chromium/public/WebInputEvent.h:169
> + bool endOfInput; // Last input event for the current vsync interval.
I think this name needs to be a bit more descriptive. The comment is good
> Source/WebKit/chromium/src/WebInputEvent.cpp:47
> + int inputData[6];
that's sad - can we fit this in somewhere else? modifiers seems to have plenty
of bits available
More information about the webkit-reviews
mailing list