[webkit-reviews] review denied: [Bug 103254] Web Inspector: make ASSERTION FAILED: foundPropertiesCount == object->size() more useful : [Attachment 176850] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 29 17:50:34 PST 2012
Yury Semikhatsky <yurys at chromium.org> has denied Peter Rybin
<prybin at chromium.org>'s request for review:
Bug 103254: Web Inspector: make ASSERTION FAILED: foundPropertiesCount ==
object->size() more useful
https://bugs.webkit.org/show_bug.cgi?id=103254
Attachment 176850: Patch
https://bugs.webkit.org/attachment.cgi?id=176850&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176850&action=review
> Source/WebCore/inspector/CodeGeneratorInspector.py:1342
> + validator_writer.newline("
FATAL(\"Unexpected properties in object: %s\\n\",
object->toJSONString().ascii().data());\n")
Now it will crash in release build too which is bad.
More information about the webkit-reviews
mailing list