[webkit-reviews] review granted: [Bug 103613] WebKit2 child processes need to initialize timer coalescing policy on Mac. : [Attachment 176697] Patch: Not ready for commit until stable OS builds available.

[bugzilla-daemon at webkit.org]

X-Bugzilla-Type: request
In-Reply-To: <bug-103613-0 at https.bugs.webkit.org/>
References: <bug-103613-0 at https.bugs.webkit.org/>

Mark Rowe (bdash) <mrowe at apple.com> has granted Kiran Muppala
<cmuppala at apple.com>'s request for review:
Bug 103613: WebKit2 child processes need to initialize timer coalescing policy
on Mac.
https://bugs.webkit.org/show_bug.cgi?id=103613

Attachment 176697: Patch: Not ready for commit until stable OS builds
available.

https://bugs.webkit.org/attachment.cgi?id=176697&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=176697&action=review


> Source/WebKit2/Shared/mac/ChildProcessMac.mm:70
> +    // Set task_latency and task_throughput qos tiers as appropriate for a
visible application.

"qos" should be written as QOS in the comment since it is an initialism.

> Source/WebKit2/Shared/mac/ChildProcessMac.mm:73
> +    struct task_qos_policy qosinfo;
> +    qosinfo.task_latency_qos_tier = LATENCY_QOS_TIER_0;
> +    qosinfo.task_throughput_qos_tier = THROUGHPUT_QOS_TIER_0;

This could be initialized on the same line as the declaration:
struct task_qos_policy qosinfo = { LATENCY_QOS_TIER_0, THROUGHPUT_QOS_TIER_0 };