[webkit-reviews] review granted: [Bug 103457] [WK2] Forward cookie jar calls to NetworkProcess : [Attachment 176752] more build fixes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 29 16:51:08 PST 2012


Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 103457: [WK2] Forward cookie jar calls to NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=103457

Attachment 176752: more build fixes
https://bugs.webkit.org/attachment.cgi?id=176752&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=176752&action=review


> Source/WebCore/platform/Cookie.h:38
> +	   Cookie() { }

Should this initialize the double and the bools?

> Source/WebKit/efl/WebCoreSupport/PlatformStrategiesEfl.cpp:87
> +String PlatformStrategiesEfl::cookiesForDOM(NetworkingContext* context,
const KURL& firstParty, const KURL& url)
> +{
> +    return WebCore::cookiesForDOM(context, firstParty, url);
> +}

Can we do this with a default implementation in the base class rather than
repeating this for every platform?


More information about the webkit-reviews mailing list