[webkit-reviews] review denied: [Bug 100650] Web Inspector: Autogenerate stack traces and line numbers when possible. : [Attachment 176762] Rebased.

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Mike West
<mkwst at chromium.org>'s request for review:
Bug 100650: Web Inspector: Autogenerate stack traces and line numbers when
possible.
https://bugs.webkit.org/show_bug.cgi?id=100650

Attachment 176762: Rebased.
https://bugs.webkit.org/attachment.cgi?id=176762&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176762&action=review


> Source/WebCore/inspector/InspectorConsoleAgent.cpp:169
> +	   document =
m_instrumentingAgents->inspectorAgent()->inspectedDocument();

m_instrumentingAgents are supposed to be read only in
InspectorInstrumentation.* If you need to access inspectorAgent you can pass it
in the constructor of InspectorConsoleAgent. But in this case you seem to need
access to the document where the message is being logged, you should pass it
directly as it main differ from the document of main frame that
inspectedDocument() returns.

>
LayoutTests/fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction-
expected.txt:3
> +FAIL gFocusedDocument.activeElement.getAttribute("id") should be start. Was
end.

Hmm, the test is failing now, we should avoid such rebaseline.