[webkit-reviews] review granted: [Bug 103673] Avoid painting lots of small rects in WebLayer painting : [Attachment 176826] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 29 15:08:44 PST 2012


Tim Horton <timothy_horton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 103673: Avoid painting lots of small rects in WebLayer painting
https://bugs.webkit.org/show_bug.cgi?id=103673

Attachment 176826: Patch
https://bugs.webkit.org/attachment.cgi?id=176826&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=176826&action=review


> Source/WebCore/platform/graphics/mac/WebLayer.mm:106
> +	       const FloatRect& currRect = dirtyRects[i];

curr? :\

> Source/WebCore/platform/graphics/mac/WebLayer.mm:114
> +	   layerContents->platformCALayerPaintContents(graphicsContext,
enclosingIntRect(clipBounds));

Shouldn't this be the union of the rects instead?


More information about the webkit-reviews mailing list