[webkit-reviews] review granted: [Bug 103623] It should be easy to find code blocks in debug dumps : [Attachment 176821] the patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 29 14:58:46 PST 2012
Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 103623: It should be easy to find code blocks in debug dumps
https://bugs.webkit.org/show_bug.cgi?id=103623
Attachment 176821: the patch
https://bugs.webkit.org/attachment.cgi?id=176821&action=review
------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=176821&action=review
r=me
> Source/JavaScriptCore/bytecode/CodeBlock.cpp:72
> + out.print(hash(), ":[", RawPointer(this), ", ", jitType, codeType());
I wonder if there's a better way to call this out as a hash. Prefix with "#"?
More information about the webkit-reviews
mailing list