[webkit-reviews] review requested: [Bug 103457] [WK2] Forward cookie jar calls to NetworkProcess : [Attachment 176752] more build fixes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 29 14:27:08 PST 2012


Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 103457: [WK2] Forward cookie jar calls to NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=103457

Attachment 176752: more build fixes
https://bugs.webkit.org/attachment.cgi?id=176752&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I think that having ifdefs in this bottleneck file is a better solution than
short term alternatives we have, so putting back under review.

The real tangible burden is having to update all platforms in lockstep, and as
evidenced by this patch, strategies don't make it very easy. Engineers working
on most ports have to pay this cost, and will inevitably be looking at ways to
improve the solution.

I don't think that adding more isolation between platforms - especially at the
cost of more duplicated code - is the right direction. It may make reading the
code easier initially, but once you try to make a patch, you are suddenly
dealing with more complicated code, multiplied.


More information about the webkit-reviews mailing list