[webkit-reviews] review granted: [Bug 103555] Make LazyDecodingPixelRef inherit from skia::LazyPixelRef so that cc thread can access it : [Attachment 176569] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 29 14:18:35 PST 2012


Stephen White <senorblanco at chromium.org> has granted Min Qin
<qinmin at chromium.org>'s request for review:
Bug 103555: Make LazyDecodingPixelRef inherit from skia::LazyPixelRef so that
cc thread can access it
https://bugs.webkit.org/show_bug.cgi?id=103555

Attachment 176569: Patch
https://bugs.webkit.org/attachment.cgi?id=176569&action=review

------- Additional Comments from Stephen White <senorblanco at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176569&action=review


OK.  r=me

> Source/WebCore/platform/graphics/chromium/LazyDecodingPixelRef.cpp:103
> +    lockPixels();
> +    unlockPixels();

Not sure I really get this, since you're going to have to lock again to use
them, but I'm sure you know that.  :)


More information about the webkit-reviews mailing list