[webkit-reviews] review denied: [Bug 103059] Web Inspector: [REGRESSION] [Styles] Rule disappears if edited selector does not affect selected node : [Attachment 176660] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 29 14:11:49 PST 2012
Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 103059: Web Inspector: [REGRESSION] [Styles] Rule disappears if edited
selector does not affect selected node
https://bugs.webkit.org/show_bug.cgi?id=103059
Attachment 176660: Patch
https://bugs.webkit.org/attachment.cgi?id=176660&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176660&action=review
Having a dedicated test case for this would be great.
> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1317
> + // This gets deleted in this._moveEditorFromSelector(), which is
called both on success and failure.
_moveEditorFromSelector is called from many other places too.
More information about the webkit-reviews
mailing list