[webkit-reviews] review granted: [Bug 103657] [New Multicolumn] Add minimum column height and forced break tracking to column sets : [Attachment 176776] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 29 11:59:57 PST 2012


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 103657: [New Multicolumn] Add minimum column height and forced break
tracking to column sets
https://bugs.webkit.org/show_bug.cgi?id=103657

Attachment 176776: Patch
https://bugs.webkit.org/attachment.cgi?id=176776&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=176776&action=review


> Source/WebCore/rendering/RenderMultiColumnSet.h:67
> +    int forcedBreaks() const { return m_forcedBreaks; }

Is this a count of forced breaks, or the locations of the breaks? It should be
renamed to clarify.


More information about the webkit-reviews mailing list