[webkit-reviews] review granted: [Bug 101150] Web Inspector: Console: hovering node wrappers in object tree should highlight them on the page : [Attachment 176012] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 29 10:48:46 PST 2012


Vsevolod Vlasov <vsevik at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 101150: Web Inspector: Console: hovering node wrappers in object tree
should highlight them on the page
https://bugs.webkit.org/show_bug.cgi?id=101150

Attachment 176012: Patch
https://bugs.webkit.org/attachment.cgi?id=176012&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176012&action=review


> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:249
> +	      
WebInspector.DOMPresentationUtils.createSpansForNodeTitle(this.valueElement,
this.property.value.description);

s/this.property.value.description/description/

> Source/WebCore/inspector/front-end/externs.js:68
> +window.isUnderTest = false;

is that related?


More information about the webkit-reviews mailing list