[webkit-reviews] review denied: [Bug 103649] [BlackBerry] Cookies in private mode should not have access to public cookies : [Attachment 176755] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied otcheung at rim.com's request for review:
Bug 103649: [BlackBerry] Cookies in private mode should not have access to
public cookies
https://bugs.webkit.org/show_bug.cgi?id=103649

Attachment 176755: Patch
https://bugs.webkit.org/attachment.cgi?id=176755&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=176755&action=review


Otto agreed to clean it up some more.

> Source/WebCore/platform/blackberry/CookieManager.cpp:512
>      if (!mode) {

It would be more readable to have it called privateMode instead of mode, but
your patch is not related to that.

> Source/WebCore/platform/blackberry/CookieManager.cpp:516
> +	   removeAllCookies(DoNotRemoveFromBackingStore);

We always do this...