[webkit-reviews] review granted: [Bug 103545] Web Inspector: introduce fast case for within-chunk edit : [Attachment 176570] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 103545: Web Inspector: introduce fast case for within-chunk edit
https://bugs.webkit.org/show_bug.cgi?id=103545

Attachment 176570: Patch
https://bugs.webkit.org/attachment.cgi?id=176570&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176570&action=review


> Source/WebCore/inspector/front-end/DefaultTextEditor.js:2424
> +	       var lastUndamagedLineRow =
lastDamagedChunk.expandedLineRow(oldRange.startLine - 1);

s/lastDamagedChunk/firstDamagedChunk/ for consistency

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:2434
> +	       firstDamagedChunk.updateCollapsedLineRow();

This could be done lazily, do you intend change that later?