[webkit-reviews] review granted: [Bug 103581] run-perf-tests --chromium-android should not require adb in my path : [Attachment 176753] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 29 10:18:33 PST 2012
Eric Seidel <eric at webkit.org> has granted Peter Beverloo <peter at chromium.org>'s
request for review:
Bug 103581: run-perf-tests --chromium-android should not require adb in my path
https://bugs.webkit.org/show_bug.cgi?id=103581
Attachment 176753: Patch
https://bugs.webkit.org/attachment.cgi?id=176753&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176753&action=review
LGTM.
> Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:35
> +import sys
It's sad to add this, but I understand why you are. We've been slowly removing
all most os and sys imports to allow for easy mocking/testing.
More information about the webkit-reviews
mailing list