[webkit-reviews] review denied: [Bug 103592] [BlackBerry] DRT - crashed on WebCore::SearchFieldCancelButtonElement : [Attachment 176687] patch - checking pointer

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Xiaobo Wang
<xiaobo.wang at torchmobile.com.cn>'s request for review:
Bug 103592: [BlackBerry] DRT - crashed on
WebCore::SearchFieldCancelButtonElement
https://bugs.webkit.org/show_bug.cgi?id=103592

Attachment 176687: patch - checking pointer
https://bugs.webkit.org/attachment.cgi?id=176687&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176687&action=review


> Source/WebCore/ChangeLog:19
> +	   (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
> +	   (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):

SearchFieldResultsButtonElement::defaultEventHandler should have a similar
change.

> Source/WebCore/html/shadow/TextControlInnerElements.cpp:200
> -    if (input->disabled() || input->readOnly()) {
> +    if (!input || input->disabled() || input->readOnly()) {

You have to update
SearchFieldCancelButtonElement::willRespondToMouseClickEvents too.

> Source/WebCore/html/shadow/TextControlInnerElements.cpp:285
> -    if (input->disabled() || input->readOnly()) {
> +    if (!input || input->disabled() || input->readOnly()) {

You have to update InputFieldSpeechButtonElement::willRespondToMouseClickEvents
too.