[webkit-reviews] review granted: [Bug 101735] [Qt] Fix installation of QtWebProcess binary : [Attachment 176498] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Andras Becsi
<abecsi at webkit.org>'s request for review:
Bug 101735: [Qt] Fix installation of QtWebProcess binary
https://bugs.webkit.org/show_bug.cgi?id=101735

Attachment 176498: Patch
https://bugs.webkit.org/attachment.cgi?id=176498&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176498&action=review


> Source/WebKit2/Shared/qt/ProcessExecutablePathQt.cpp:51
> +#if USE(LIBEXECDIR)
> +    expectedPath =
QLibraryInfo::location(QLibraryInfo::LibraryExecutablesPath) +
QDir::separator() + baseName;
> +    if (QFile::exists(expectedPath))
> +	   return String(expectedPath);
> +#endif
> +
>      expectedPath = QLibraryInfo::location(QLibraryInfo::BinariesPath) +
QDir::separator() + baseName;
>      if (QFile::exists(expectedPath))
>	   return String(expectedPath);

This could be an #else ... #endif here. Feel free to change before landing :)