[webkit-reviews] review granted: [Bug 103492] Disassembly methods should be able to disassemble to any PrintStream& rather than always using WTF::dataFile() : [Attachment 176589] the patch

[bugzilla-daemon at webkit.org]

Mark Hahnenberg <mhahnenberg at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 103492: Disassembly methods should be able to disassemble to any
PrintStream& rather than always using WTF::dataFile()
https://bugs.webkit.org/show_bug.cgi?id=103492

Attachment 176589: the patch
https://bugs.webkit.org/attachment.cgi?id=176589&action=review

------- Additional Comments from Mark Hahnenberg <mhahnenberg at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=176589&action=review


r=me with the one comment change.

> Source/JavaScriptCore/dfg/DFGGraph.cpp:219
> +		   out.print(", "); // If this is the third child is the first
non-empty one then make sure we have two blanks preceding it.

"If the third child is the first non-empty one then make sure we have two
blanks preceding it." ?