[webkit-reviews] review denied: [Bug 103306] Support custom V8 bindings for WebWorkers : [Attachment 176547] Proposed patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Marshall Greenblatt
<marshall at chromium.org>'s request for review:
Bug 103306: Support custom V8 bindings for WebWorkers
https://bugs.webkit.org/show_bug.cgi?id=103306

Attachment 176547: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=176547&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176547&action=review


This generally looks like a good approach.  Would you be willing to write a
unit test in Source/WebKit/chromium/tests ?  That's especially important for an
API like this that won't be tested by the Chromium project's continuous
integration system otherwise.

> WebCore/bindings/v8/WorkerContextExecutionProxy.cpp:60
> +#if PLATFORM(CHROMIUM)

No need for PLATFORM(CHROMIUM) in bindings/v8.	Chromium is the only port that
uses V8 currently.