[webkit-reviews] review granted: [Bug 95890] seamless iframes should not inherit editability : [Attachment 176526] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 28 12:21:59 PST 2012


Ojan Vafai <ojan at chromium.org> has granted Mike West <mkwst at chromium.org>'s
request for review:
Bug 95890: seamless iframes should not inherit editability
https://bugs.webkit.org/show_bug.cgi?id=95890

Attachment 176526: Patch
https://bugs.webkit.org/attachment.cgi?id=176526&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176526&action=review


Thanks!

>
LayoutTests/fast/frames/seamless/seamless-contenteditable-not-inherited.html:10

> +	       window.span = document.querySelector('div >
iframe').contentDocument.querySelector('span');
> +	       window.p = document.querySelector('body >
iframe').contentDocument.querySelector('p');

Nit: This is fine, but I would have just made them globals (e.g.
s/window.span/span/).


More information about the webkit-reviews mailing list