[webkit-reviews] review granted: [Bug 103542] [Chromium] Remove pluginsScriptableObject from PlatformSupport : [Attachment 176533] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Mark Pilgrim (Google)
<pilgrim at chromium.org>'s request for review:
Bug 103542: [Chromium] Remove pluginsScriptableObject from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=103542

Attachment 176533: Patch
https://bugs.webkit.org/attachment.cgi?id=176533&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176533&action=review


> Source/WebCore/bindings/v8/ScriptController.cpp:525
>      if (widget->isFrameView())
>	   return 0;

in WebCore/bindings/js/ScriptController.cpp, the test is:

    if (!widget->isPluginView())
	return 0;

We should probably change this line here to:

    if (!widget->isPluginViewBase())
	return 0;

to ensure that the static_cast to PluginViewBase on like 527 is safe.

> Source/WebCore/plugins/PluginViewBase.h:35
> +#else

Sorry for steering you wrong on change.  We probably want to use a USE(JSC)
ifdef for the JSC stuff rather than assuming that !USE(V8) is JSC.