[webkit-reviews] review denied: [Bug 103510] Reduce the children repaints when moved multiple times during the layout : [Attachment 176463] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 103510: Reduce the children repaints when moved multiple times during the
layout
https://bugs.webkit.org/show_bug.cgi?id=103510

Attachment 176463: Patch
https://bugs.webkit.org/attachment.cgi?id=176463&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176463&action=review


> Source/WebCore/ChangeLog:11
> +	   No new tests. Covered by existing tests in css3/flexbox.

Can you make a repaint test that shows the improvement?

> Source/WebCore/rendering/RenderFlexibleBox.h:81
> +    typedef WTF::HashMap<const RenderBox*, LayoutRect> ChildrenFrameRect;

Can we use a Vector<LayoutRect> instead of a HashMap?