[webkit-reviews] review denied: [Bug 103475] documentElement should not always get a renderer : [Attachment 176428] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 28 08:47:20 PST 2012


Stephen Chenney <schenney at chromium.org> has denied Elliott Sprehn
<esprehn at chromium.org>'s request for review:
Bug 103475: documentElement should not always get a renderer
https://bugs.webkit.org/show_bug.cgi?id=103475

Attachment 176428: Patch
https://bugs.webkit.org/attachment.cgi?id=176428&action=review

------- Additional Comments from Stephen Chenney <schenney at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176428&action=review


> Source/WebCore/svg/SVGSVGElement.cpp:478
> +    if (isOutermostSVGSVGElement())

Even non-outermost <svg> elements need renderers, so this method should return
true always, I think. See if that fixes the failing tests (which I do not
believe to be flakes).


More information about the webkit-reviews mailing list