[webkit-reviews] review requested: [Bug 100964] [Qt] Make sure that the WebView in flickable mode sends mouse events to the page rather than controlling the viewport with it : [Attachment 176491] Patch

[bugzilla-daemon at webkit.org]

Jocelyn Turcotte <jocelyn.turcotte at digia.com> has asked  for review:
Bug 100964: [Qt] Make sure that the WebView in flickable mode sends mouse
events to the page rather than controlling the viewport with it
https://bugs.webkit.org/show_bug.cgi?id=100964

Attachment 176491: Patch
https://bugs.webkit.org/attachment.cgi?id=176491&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
I tested with the mac trackpad and it's not sending touch events for single
touch. When using multiple fingers it doesn't send mouse move events. The only
problem is that it sends wheel events at the same time as touch events when
doing two-fingers scroll, but this is also the reason why they were disabled by
default one month ago:
https://qt.gitorious.org/qt/qtbase/commit/adb156e4dd64609ba6c0b172e9c428a79e306
a7c .

Ideally I guess that we should just handle gestures directly for those devices
rather than doing gesture recognition directly ourselves. That would also help
support stuff like that magic mouse that I've read aren't sending individual
touch events.

So anyway here is the patch. I'll do some more work to try showing scroll bars
in MiniBrowser and maybe handle ctrl-wheel directly in WebView to make it
easier to handle it with the mouse.