[webkit-reviews] review granted: [Bug 100095] Web Inspector: Console message's anchor element should be trimmed for readability. : [Attachment 176202] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 28 07:03:58 PST 2012


Pavel Feldman <pfeldman at chromium.org> has granted Mike West
<mkwst at chromium.org>'s request for review:
Bug 100095: Web Inspector: Console message's anchor element should be trimmed
for readability.
https://bugs.webkit.org/show_bug.cgi?id=100095

Attachment 176202: Patch
https://bugs.webkit.org/attachment.cgi?id=176202&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176202&action=review


Please fix the nit prior to landing.

> Source/WebCore/inspector/front-end/inspector.js:997
> +WebInspector.MaxLengthForDisplayedURLs = 150;

inspectot.js is currently not compiled - it depends from the universe. We
should declare constants in common places instead. Such as
WebInspector.Linkifier.MaxLengthForDisplayedURLs


More information about the webkit-reviews mailing list