[webkit-reviews] review granted: [Bug 103355] Fix gesture scrolling when the target-element of scroll-begin is removed : [Attachment 176281] Changed the logic a little bit to fix the failing tests.

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Sadrul Habib Chowdhury
<sadrul at chromium.org>'s request for review:
Bug 103355: Fix gesture scrolling when the target-element of scroll-begin is
removed
https://bugs.webkit.org/show_bug.cgi?id=103355

Attachment 176281: Changed the logic a little bit to fix the failing tests.
https://bugs.webkit.org/attachment.cgi?id=176281&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176281&action=review


>>> Source/WebCore/page/EventHandler.cpp:287
>>> +		 return firstNode;
>> 
>> could you explain this part? is firstNode ensured to be scrollable?
> 
> It's not. If there is no scrollable node in the document that contains
|node|, then this function returns the original node that was sent to the
function (which is why the 'IfPossible' suffix), i.e. the node from the
hit-test result.
> 
> The current behaviour is that it always uses the node from the hit test
result. The change in this patch tries to use a scrollable node that contains
the hit node. But if there is no such scrollable node, then it falls back to
the current behaviour.

Ah I was confusing ISdocumentNode with InDocument method. It makes sense, sure.
r+