[webkit-reviews] review granted: [Bug 103481] [Shadow] Move Distribution stuffs from ShadowRoot : [Attachment 176450] Patch

[bugzilla-daemon at webkit.org]

Hajime Morrita <morrita at google.com> has granted Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 103481: [Shadow] Move Distribution stuffs from ShadowRoot
https://bugs.webkit.org/show_bug.cgi?id=103481

Attachment 176450: Patch
https://bugs.webkit.org/attachment.cgi?id=176450&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=176450&action=review


> Source/WebCore/ChangeLog:10
> +	   Since <input> or <textarea> do not have such stuffs, the members
consume a few amount of memory.

s/stuffs/stuff/

> Source/WebCore/dom/ShadowRoot.cpp:352
> +    return distributionData()->numberOfShadowElementChildren() > 0;

hasXXX could be a method on ShadowRootContentDistributionData

> Source/WebCore/dom/ShadowRoot.cpp:370
> +    return distributionData()->numberOfContentElementChildren() > 0;

Ditto.

> Source/WebCore/dom/ShadowRoot.cpp:389
> +    return distributionData()->numberOfElementShadowChildren() > 0;

Ditto.