[webkit-reviews] review canceled: [Bug 103498] Regression(r135962): ASSERTION FAILED: !m_pedningSyncBackingStores.contains(layer) : [Attachment 176441] Patch

[bugzilla-daemon at webkit.org]

Christophe Dumez <christophe.dumez at intel.com> has canceled  review:
Bug 103498: Regression(r135962): ASSERTION FAILED:
!m_pedningSyncBackingStores.contains(layer)
https://bugs.webkit.org/show_bug.cgi?id=103498

Attachment 176441: Patch
https://bugs.webkit.org/attachment.cgi?id=176441&action=review

------- Additional Comments from Christophe Dumez <christophe.dumez at intel.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=176441&action=review


>> Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:455
>>	    return;
> 
> If I understand correctly the ASSERT happens when two async operations happen
before the commit happen.
> In this case it's a bit weird, since you're going to delay setting this
layers backing store to 0 while it's already 0. So basically you could just
remove it's key from the map.
> 
> Maybe it would be better to explicitely check if the layer is already in
m_pendingSyncBackingStores instead of assuming that getBackingStore will do
(and won't change in the future).

You are right, I can improve this. I'll upload a new proposal soon.