[webkit-reviews] review granted: [Bug 102968] Support proper <percent> / calc() resolution for grid items : [Attachment 176064] Proposed change 3: Added a comment about box-sizing and updated to fully pass the tests.

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 102968: Support proper <percent> / calc() resolution for grid items
https://bugs.webkit.org/show_bug.cgi?id=102968

Attachment 176064: Proposed change 3: Added a comment about box-sizing and
updated to fully pass the tests.
https://bugs.webkit.org/attachment.cgi?id=176064&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176064&action=review


Would be nice to have some test cases of percent grid items inside percentage
sized grids and grid track. Even if we fail them now, I think it's fine to
check them in.

> Source/WebCore/rendering/RenderBox.cpp:1321
>      if (!region)

Not sure how regions and grids are supposed to interact. But this might deserve
a FIXME for the region case since it won't use the override.