[webkit-reviews] review granted: [Bug 103382] PDFPlugin: Scroll bars do not grow on hover : [Attachment 176213] patch

[bugzilla-daemon at webkit.org]

Beth Dakin <bdakin at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 103382: PDFPlugin: Scroll bars do not grow on hover
https://bugs.webkit.org/show_bug.cgi?id=103382

Attachment 176213: patch
https://bugs.webkit.org/attachment.cgi?id=176213&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=176213&action=review


> Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:436
> +	   if (magnification) {

I don't think you need these brackets.

> Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:566
> +	   } else if (targetScrollbarForLastMousePosition)

Is 'else if' right here? Will there ever be a situation where you want to sent
a mouseEntered for one scrollbar AND a mouseExited for another?