[webkit-reviews] review granted: [Bug 103092] [chromium] Allow plugins to opt-in to receive synthetic mouse events out of touch events. : [Attachment 176295] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Sadrul Habib Chowdhury
<sadrul at chromium.org>'s request for review:
Bug 103092: [chromium] Allow plugins to opt-in to receive synthetic mouse
events out of touch events.
https://bugs.webkit.org/show_bug.cgi?id=103092

Attachment 176295: Patch
https://bugs.webkit.org/attachment.cgi?id=176295&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176295&action=review


> Tools/DumpRenderTree/chromium/TestWebPlugin.cpp:124
> +    static const WebString kPrimitiveRaw = WebString::fromUTF8("raw");
> +    static const WebString kPrimitiveSynthetic =
WebString::fromUTF8("synthetic");

Please use DEFINE_STATIC_LOCAL or use a const char* and convert it to a
WebString during the if condition.  I'm pretty sure clang will complain about
this as is.