[webkit-reviews] review granted: [Bug 101346] No condition present to check if Compressed Texture S3TC extension support exists : [Attachment 175505] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 27 10:54:02 PST 2012
Kenneth Russell <kbr at google.com> has granted akaushik at rim.com's request for
review:
Bug 101346: No condition present to check if Compressed Texture S3TC extension
support exists
https://bugs.webkit.org/show_bug.cgi?id=101346
Attachment 175505: Patch
https://bugs.webkit.org/attachment.cgi?id=175505&action=review
------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=175505&action=review
Sorry for the delay getting back to this. Looks good; r=me. Please make the
requested cleanups. You can then add my name to the "Reviewed by" line by hand,
upload a revised patch, and any committer can cq+ it.
> LayoutTests/ChangeLog:4
> + LayoutTests:
Remove this and surrounding blank lines.
> LayoutTests/fast/canvas/webgl/webgl-compressed-texture-s3tc.html:1
> +<!DOCTYPE html>
Please clean up the weird characters at the beginning of this line.
More information about the webkit-reviews
mailing list