[webkit-reviews] review granted: [Bug 103276] Fix occlusion culling logic to handle css background layer clipping : [Attachment 176067] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Justin Novosad
<junov at google.com>'s request for review:
Bug 103276: Fix occlusion culling logic to handle css background layer clipping
https://bugs.webkit.org/show_bug.cgi?id=103276

Attachment 176067: Patch
https://bugs.webkit.org/attachment.cgi?id=176067&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=176067&action=review


> Source/WebCore/rendering/RenderBox.cpp:1008
> +void RenderBox::recursivePaintFillLayers(const PaintInfo& paintInfo, const
Color& c, const FillLayer* fillLayer, const LayoutRect& rect,
> +    BackgroundBleedAvoidance bleedAvoidance, CompositeOperator op,
RenderObject* backgroundObject, bool firstLayer)

I'd prefer this not be recursive. I see no reason why we can't just paint
layers in a loop.

> Source/WebCore/rendering/style/FillLayer.cpp:268
> +    if (clipA == BorderFillBox || clipB == BorderFillBox)
> +	   return BorderFillBox;
> +    if (clipA == PaddingFillBox || clipB == PaddingFillBox)
> +	   return BorderFillBox;
> +    if (clipA == ContentFillBox || clipB == ContentFillBox)
> +	   return BorderFillBox;

Is this right? Why return BorderFillBox every time?