[webkit-reviews] review denied: [Bug 103255] Log to console when autofocus is blocked by sandbox attribute. : [Attachment 176256] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 27 10:03:23 PST 2012
Ojan Vafai <ojan at chromium.org> has denied Mike West <mkwst at chromium.org>'s
request for review:
Bug 103255: Log to console when autofocus is blocked by sandbox attribute.
https://bugs.webkit.org/show_bug.cgi?id=103255
Attachment 176256: Patch
https://bugs.webkit.org/attachment.cgi?id=176256&action=review
------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176256&action=review
The test needs a bit of work, but this looks good to me otherwise.
> LayoutTests/fast/forms/autofocus-in-sandbox-without-allow-scripts.html:4
> +</script>
Would be good to have a textual description of what this test is testing so
people can know if the output is correct.
>> LayoutTests/fast/forms/autofocus-in-sandbox-without-allow-scripts.html:6
>> + src="data:text/html,<input autofocus onfocus>"></iframe>
>
> I would have put this in the sandbox test suite.
And no need to wrap this line.
More information about the webkit-reviews
mailing list