[webkit-reviews] review denied: [Bug 103231] Use AtomicString instead of AtomicStringImpl* in WebCore::RuleSet. : [Attachment 175956] Add isNull() check.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 27 08:49:47 PST 2012
Antti Koivisto <koivisto at iki.fi> has denied Hayato Ito <hayato at chromium.org>'s
request for review:
Bug 103231: Use AtomicString instead of AtomicStringImpl* in WebCore::RuleSet.
https://bugs.webkit.org/show_bug.cgi?id=103231
Attachment 175956: Add isNull() check.
https://bugs.webkit.org/attachment.cgi?id=175956&action=review
------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=175956&action=review
> Source/WebCore/ChangeLog:8
> + Using AtomicString is preferred to using *AtomicStringImpl directly.
We
Rules like that exist to help people avoid mistakes with things they don't
understand. This code is safe, the change just increases ref churn.
More information about the webkit-reviews
mailing list