[webkit-reviews] review granted: [Bug 73002] Incorrect value of CSSStyleDeclaration#length when a shorthand property is inherit or initial : [Attachment 175995] Patch

[bugzilla-daemon at webkit.org]

Alexis Menard (darktears) <alexis at webkit.org> has granted Alexander Pavlov
(apavlov) <apavlov at chromium.org>'s request for review:
Bug 73002: Incorrect value of CSSStyleDeclaration#length when a shorthand
property is inherit or initial
https://bugs.webkit.org/show_bug.cgi?id=73002

Attachment 175995: Patch
https://bugs.webkit.org/attachment.cgi?id=175995&action=review

------- Additional Comments from Alexis Menard (darktears) <alexis at webkit.org>
It makes the length of the style finally consistent no matter if you set
inherit, initial, or any value. It matches Firefox and Opera (at least for
inherit, the latter seems to not expand initial). We are not patching the
computed style here but the declaration so "initial" and "inherit" are possible
return values in that case. Indeed we're the only browser supporting that : for
example elem.style.background = "inherit"; elem.style.background will return
"inherit" as is today and it's valid for any other property. Antti has a good
suggestion on moving out the property expansion and construction out of
StylePropertySet if there is no internal clients and I think it could be done
(provided it's feasible) in a latter patch, moving altogether what's need to be
moved.