[webkit-reviews] review granted: [Bug 103376] [V8] add contextForWorld helper function to ScriptController : [Attachment 176195] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 27 01:14:40 PST 2012


Kentaro Hara <haraken at chromium.org> has granted Dan Carney
<dcarney at google.com>'s request for review:
Bug 103376: [V8] add contextForWorld helper function to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=103376

Attachment 176195: Patch
https://bugs.webkit.org/attachment.cgi?id=176195&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176195&action=review


> Source/WebCore/bindings/v8/ScriptController.cpp:437
> +inline v8::Local<v8::Context>
ScriptController::contextForWorld(DOMWrapperWorld* world)

This could be in a header file. Maybe you couldn't write it in a header file
due to some #include dependency problem ?


More information about the webkit-reviews mailing list