[webkit-reviews] review granted: [Bug 102861] Implement ValidityState::badInput : [Attachment 175940] Patch 5

[bugzilla-daemon at webkit.org]

Hajime Morrita <morrita at google.com> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 102861: Implement ValidityState::badInput
https://bugs.webkit.org/show_bug.cgi?id=102861

Attachment 175940: Patch 5
https://bugs.webkit.org/attachment.cgi?id=175940&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=175940&action=review


> Source/WebCore/ChangeLog:17
> +	   interactive validation tells it.

Better to use consistent tense.

> Source/WebCore/ChangeLog:27
> +	   will be added later.

The bug# might be worth being mentioned here.

> Source/WebCore/html/FormAssociatedElement.h:79
>      // stepMismatch, tooLong and valueMissing must call willValidate method.


Vaguely feel that it's time to fold these into one method which returns bit
flags.