[webkit-reviews] review denied: [Bug 103251] [Chromium] Implement XHR2 timeout for chromium port : [Attachment 176187] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Wei James (wistoch)
<james.wei at intel.com>'s request for review:
Bug 103251: [Chromium] Implement XHR2 timeout for chromium port
https://bugs.webkit.org/show_bug.cgi?id=103251

Attachment 176187: Patch
https://bugs.webkit.org/attachment.cgi?id=176187&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176187&action=review


It's not clear to me what we want to implement this feature in Chromium.

> Source/WebCore/platform/network/chromium/ResourceHandle.cpp:180
> +    // Use the same value as in NSURLError.h
> +    static const int timeoutError = -1001;
> +    static const char* const errorDomain = "WebKitNetworkError";

Why should Chromium code use values based on the Mac OS X APIs?

> Source/WebKit/chromium/features.gypi:127
> -	 'ENABLE_XHR_TIMEOUT=0',
> +	 'ENABLE_XHR_TIMEOUT=1',

Please don't flip this bit unless this feature has been approved for inclusion
in the Chromium port.