[webkit-reviews] review granted: [Bug 103350] :read-only selector should match to date/time input types : [Attachment 176180] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 103350: :read-only selector should match to date/time input types
https://bugs.webkit.org/show_bug.cgi?id=103350

Attachment 176180: Patch
https://bugs.webkit.org/attachment.cgi?id=176180&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176180&action=review


Looks ok

> Source/WebCore/ChangeLog:11
> +	   isTextFormControl check in SeelctorChecker, and just relies on

Typo: SelectorChecker

> Source/WebCore/html/HTMLTextAreaElement.cpp:539
> +bool HTMLTextAreaElement::shouldMatchReadOnlySelector() const
> +{
> +    return readOnly();
> +}
> +
> +bool HTMLTextAreaElement::shouldMatchReadWriteSelector() const
> +{
> +    return !readOnly();

Don't you want to change this to:

  bool HTMLTextAreaElement::shouldMatchReadOnlySelector() const
  {
    return supportsReadOnly() && readOnly();
  }

  bool HTMLTextAreaElement::shouldMatchReadWriteSelector() const
  {
    return supportsReadOnly() && !readOnly();
  }

and implement:

  HTMLTextAreaElement::supportsReadOnly() { return true; }

?